[ 
https://issues.apache.org/jira/browse/IGNITE-13078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125484#comment-17125484
 ] 

Ivan Daschinskiy commented on IGNITE-13078:
-------------------------------------------

[~isapego] Thank you for review

1. Ok, got it.
2. It seems that I forgot to remove link to odbcinst, it should work with 
${ODBC_LIBBRARY}
3. Tests are optional, but its possible to add check if directory exists
4. I have consultancy with [~dmitry.pavlov], he said that its absolutely ok, 
but one more notice in LICENCE should be added. Actually, I changed this script 
a little bit in order to be compatible with older cmake 3


It's nice to heat, that it works with VS without big issues. I don't expect 
this, but it seems that we go to right direction and finally our project will 
have unified cross platform build system. 


> С++: Add CMake build support
> ----------------------------
>
>                 Key: IGNITE-13078
>                 URL: https://issues.apache.org/jira/browse/IGNITE-13078
>             Project: Ignite
>          Issue Type: Improvement
>          Components: platforms
>            Reporter: Ivan Daschinskiy
>            Assignee: Ivan Daschinskiy
>            Priority: Major
>             Fix For: 2.9
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, it is hard to build Ignite.C++. Different build process for 
> windows and linux, lack of building support on Mac OS X (quite popular OS 
> among developers), absolutely not IDE support, except windows and only Visual 
> Studio is supported.
> I’d suggest to migrate to CMake build system. It is very popular among open 
> source projects, and in Apache Software Foundation too. Notable user: Apache 
> Mesos, Apache Zookeeper (C client offers CMake as an alternative to autoconf 
> and only option on windows), Apache Kafka (librdkafka - C/C++ client), Apache 
> Thrift. Popular column-oriented database ClickHouse also uses CMake.
> CMake is widely supported in many IDE’s on various platforms, notably Visual 
> Studio, CLion, Xcode, QtCreator, KDevelop.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to