[ 
https://issues.apache.org/jira/browse/IGNITE-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093454#comment-15093454
 ] 

Semen Boikov commented on IGNITE-2350:
--------------------------------------

I reviewed your changes and have few comments:
- we can not remove ATTR_UPDATE_NOTIFIER_ENABLED attribute since it is public, 
lets leave it as is
- lets add try/catch for 'getAndPutIfAbsent' to be on the safe side
- IgniteUpdateNotifierPerClusterSettingSelfTest is not added in suites

> Make IGNITE_UPDATE_NOTIFIER per cluster setting
> -----------------------------------------------
>
>                 Key: IGNITE-2350
>                 URL: https://issues.apache.org/jira/browse/IGNITE-2350
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Yakov Zhdanov
>            Assignee: Artem Shutak
>            Priority: Critical
>              Labels: important
>             Fix For: 1.6
>
>
> We need to refactor update notification behavior to make it more transparent.
> # The first node (topVer=1) should behave in accordance to its local settings
> # The first node should set cluster-wide default which should survive its 
> (first node) exit.
> # Further nodes should ignore local setting and respect cluster wide value 
> set on cluster start



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to