[ 
https://issues.apache.org/jira/browse/IGNITE-1993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052673#comment-15052673
 ] 

Nigel Westbury commented on IGNITE-1993:
----------------------------------------

Hi Nikolav,

Thanks for testing it.  I was wondering if you were testing with the attached 
patch or were testing the code in the pull 
request.  Unfortunately the patch did create an error introduced when i did 
some last minute code clean-up while 
submitting the patch.  Sorry about that.  That patch was superceded by the 
pull-request as Denis said not to submit as 
a patch.  Table names passed to the metadata tables request in upper case.  
Using lower case does not work with 
Oracle even if the table was created with lower case characters.

If you are testing the pull-request then I am surprised as it works with Oracle 
here.

I don't think Ignite should allow user configuration of SQL unless really 
necessary.  In any case the query of the 
metadata is not done using SQL, it is JDBC API, so allowing user configurable 
SQL would not help here.  Though I 
have not tested with various different databases, in my experience the JDBC 
metadata API is consistently implemented 
by the various drivers I have used from time to time.


> JDBC discovery uses non-standard SQL when creating table (not compatible with 
> Oracle)
> -------------------------------------------------------------------------------------
>
>                 Key: IGNITE-1993
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1993
>             Project: Ignite
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: ignite-1.4
>         Environment: Oracle database
>            Reporter: Nigel Westbury
>              Labels: easyfix, patch
>             Fix For: 1.4
>
>         Attachments: IGNITE1993.patch
>
>
> The SQL used by TcpDiscoveryJdbcIpFinder to create the table (defined by 
> CREATE_ADDRS_TABLE_QRY) uses 'if not exists' clause.  However this clause is 
> not supported by Oracle and causes SQLSyntaxErrorException: "ORA-00922: 
> missing or invalid option" to be thrown.  This prevents JDBC discovery from 
> being used with an Oracle database.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to