[ https://issues.apache.org/jira/browse/IGNITE-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942633#comment-14942633 ]
ASF GitHub Bot commented on IGNITE-708: --------------------------------------- GitHub user murador opened a pull request: https://github.com/apache/ignite/pull/129 IGNITE-708: Remove refreshPartitions on ResendTimeoutObject. IGNITE-708: From what I could see, the refresh partition in case of timeout is redundant, since each node has a refresh partition which runs at regular intervals in the method body() of GridCachePartitionExchangeManager retrieved from the background process ExchangeWorker. Thus eliminating the refreshPartition in ResendTimeoutObject class should not have any impact on the operation, but an increase in performance when we avoid sending redundant message. You can merge this pull request into a Git repository by running: $ git pull https://github.com/murador/ignite IGNITE-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/129.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #129 ---- commit bfe23fb8eca05d67ec4c3e195c9a972616072c93 Author: murador <miten...@gmail.com> Date: 2015-10-04T10:45:18Z Remove refreshPartitions on ResendTimeoutObject. ---- > Need to remove background partition exchange > -------------------------------------------- > > Key: IGNITE-708 > URL: https://issues.apache.org/jira/browse/IGNITE-708 > Project: Ignite > Issue Type: Task > Affects Versions: ignite-1.4 > Reporter: Yakov Zhdanov > Assignee: Gianfranco Murador > Priority: Blocker > Labels: datagrid > Fix For: ignite-1.5, ignite-1.6 > > > Now every node sends its partition map to cache coordinator (which is the > oldest node in topology) and coordinator spreads full partition map to every > node in topology. This happens for each cache separately. This seems to take > place even if there were no changes to local partition maps. Given we > guarantee communication message delivery this background process seems to be > an overkill. > Exchange should happen only if any changes took place. > After dynamic cache start has been introduced, we can have significant amount > of live caches at some point of app lifecycle and app may suffer from > background exchange which is obviously not a requirement (and may be never > has been the one). -- This message was sent by Atlassian JIRA (v6.3.4#6332)