[ 
https://issues.apache.org/jira/browse/IGNITE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933379#comment-14933379
 ] 

Anton Vinogradov commented on IGNITE-429:
-----------------------------------------

Gianfranco,
Thanks for your pull request!

I'd like to ask you make some changes before review:
1) Please refactor code according to Ignite Coding Guidelines. See 
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines for 
details. I recommend to configure IDEA codestyle.
Important part: According to 
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-SemanticUnits
To simplify the recognition of semantic units, the every line of the source 
code should be separated by one empty line except some cases, see wiki for 
details.
2) All fields should be marked as final in case they are immutable.
3) Remove @author comments.
4) Use explicit imports only.
5) Could you please (next time) update existing pull request instead of 
creating new.

> Implement IgniteStormStreamer to stream data from Apache Storm
> --------------------------------------------------------------
>
>                 Key: IGNITE-429
>                 URL: https://issues.apache.org/jira/browse/IGNITE-429
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: streaming
>            Reporter: Dmitriy Setrakyan
>            Assignee: Chandresh Pancholi
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under 
> high load. It was previously named {{IgniteDataLoader}}, see ticket 
> IGNITE-394.
> See [Apache Storm|https://storm.apache.org/] for more information.
> We should create {{IgniteStormStreamer}} which will consume tuples from Storm 
> and stream them into Ignite caches. 
> More details to follow, but to the least we should be able to:
> - Convert/Intercept Storm tuples to Ignite data using an optional pluggable 
> converter.
> - Specify the cache name for the Ignite cache to load data into.
> - Specify other flags available on {{IgniteDataStreamer}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to