[ 
https://issues.apache.org/jira/browse/IGNITE-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14730267#comment-14730267
 ] 

Valentin Kulichenko commented on IGNITE-1016:
---------------------------------------------

Andrey,

Can you explain {{else if (force && !excludeNeighbors) {}} line of code? It 
looks like with your changes the code inside this if will never be executed if 
{{excludeNeighbors == true}}, which looks suspicious because it existed without 
this configuration parameter.

Also you created {{AffinityUtils}} class on public API - this is wrong. Please 
move its methods to {{CacheUtils}}.

> Add excludeNeighbors and backupFilter to FairAffinityFunction
> -------------------------------------------------------------
>
>                 Key: IGNITE-1016
>                 URL: https://issues.apache.org/jira/browse/IGNITE-1016
>             Project: Ignite
>          Issue Type: Bug
>          Components: cache
>    Affects Versions: sprint-4
>            Reporter: Valentin Kulichenko
>            Assignee: Valentin Kulichenko
>              Labels: Usability
>             Fix For: ignite-1.4
>
>         Attachments: ignite-1016.patch, ignite-1016.patch
>
>
> These properties are currently available only for 
> {{RendezvousAffinityFunction}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to