Copilot commented on code in PR #3173:
URL: https://github.com/apache/hugegraph/pull/3173#discussion_r3882674522
##########
.github/workflows/server-ci.yml:
##########
@@ -12,7 +12,7 @@ jobs:
wait-storage-shell-test:
permissions:
contents: read
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-24.04
Review Comment:
The PR title/description says to run Linux jobs on Ubuntu 24.04
consistently, but the workflow is updated to `ubuntu-latest` rather than
`ubuntu-24.04`. If the goal is specifically 24.04, please pin both jobs to
`runs-on: ubuntu-24.04` (more deterministic and matches the PR intent). If the
goal is to always follow GitHub’s latest Ubuntu image, please update the PR
title/description accordingly.
##########
.github/workflows/server-ci.yml:
##########
@@ -12,7 +12,7 @@ jobs:
wait-storage-shell-test:
permissions:
contents: read
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-24.04
Review Comment:
Using `ubuntu-latest` can cause unplanned CI breakages when GitHub advances
the default Ubuntu version (toolchain/package versions can change underneath
you). If stability/reproducibility is important for these jobs, prefer pinning
to `ubuntu-24.04` and bump intentionally when ready.
##########
.github/workflows/server-ci.yml:
##########
@@ -23,8 +23,7 @@ jobs:
run:
hugegraph-server/hugegraph-dist/src/assembly/travis/test-wait-storage.sh
build-server:
- # TODO: we need test & replace it to ubuntu-24.04 or ubuntu-latest
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-24.04
Review Comment:
The PR title/description says to run Linux jobs on Ubuntu 24.04
consistently, but the workflow is updated to `ubuntu-latest` rather than
`ubuntu-24.04`. If the goal is specifically 24.04, please pin both jobs to
`runs-on: ubuntu-24.04` (more deterministic and matches the PR intent). If the
goal is to always follow GitHub’s latest Ubuntu image, please update the PR
title/description accordingly.
##########
.github/workflows/server-ci.yml:
##########
@@ -23,8 +23,7 @@ jobs:
run:
hugegraph-server/hugegraph-dist/src/assembly/travis/test-wait-storage.sh
build-server:
- # TODO: we need test & replace it to ubuntu-24.04 or ubuntu-latest
- runs-on: ubuntu-22.04
+ runs-on: ubuntu-24.04
Review Comment:
Using `ubuntu-latest` can cause unplanned CI breakages when GitHub advances
the default Ubuntu version (toolchain/package versions can change underneath
you). If stability/reproducibility is important for these jobs, prefer pinning
to `ubuntu-24.04` and bump intentionally when ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
