lokidundun commented on PR #357:
URL: 
https://github.com/apache/hugegraph-computer/pull/357#issuecomment-5139564106

   > ## Pull request overview
   > Copilot reviewed 7 out of 7 changed files in this pull request and 
generated no new comments.
   > 
   > Suppressed comments (1)
   > 
**computer/computer-test/src/main/java/org/apache/hugegraph/computer/suite/integrate/SenderIntegrateTest.java:91**
   > 
   > * The master options builder sets rpcServerPort twice (8611 and then 0). 
This is redundant and makes it harder to tell which port is actually used; 
`convertToMap()` will silently let the later value win. Please remove the fixed 
port and keep only the ephemeral port (0).
   > 
   > ```
   >                                           .withRpcServerHost("127.0.0.1")
   >                                           .withRpcServerPort(8611)
   >                                         .withRpcServerPort(0)
   > ```
   
   This duplicate configuration predates the PR and is unrelated to the current 
fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to