imbajin commented on code in PR #3127:
URL: https://github.com/apache/hugegraph/pull/3127#discussion_r3678540696
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/task/HugeTask.java:
##########
@@ -575,9 +575,29 @@ protected synchronized Object[] asArray() {
if (this.result != null) {
byte[] bytes = StringEncoding.compress(this.result);
- checkPropertySize(bytes.length, P.RESULT);
- list.add(P.RESULT);
- list.add(bytes);
+ int chunkSize =
CoreOptions.instance().get(CoreOptions.TASK_RESULT_CHUNK_SIZE);
+
+ if (chunkSize > 0 && bytes.length > chunkSize) {
Review Comment:
‼️ This is not the shared persisted-result path.
`TaskAndResultScheduler.save()` stores task metadata through
`asArrayWithoutResult()` and writes the result through unchanged
`HugeTaskResult.asArray()`, so HStore/distributed deployments still persist one
BLOB; `HugeTask.set()` also enforces the total result limit before this branch
runs. Please center chunking in the actual result-storage abstraction and cover
both local and distributed persistence, including old-format compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
