bitflicker64 commented on PR #3105: URL: https://github.com/apache/hugegraph/pull/3105#issuecomment-5102461486
**Self-review on `d4dc7d2b`** — things I found reading my own diff, none of them raised in review: - PD/Store `process_num` / `process_id` still carried a changed contract while the server copy was already reverted. All three match master now — item 12 claimed this and it was only two-thirds true. - The PD and Store images installed `lsof` purely for the `check_port` this PR deletes. Removed; they run no preflight, so unlike the server images nothing replaces it. - Test suite: the tally file was cleaned only on the normal exit path — a SIGTERM mid-run leaked one temp file on the previous head, none now. And `sleep 0.5` → `sleep 1`, since fractional sleep is not POSIX and the suite runs `set -u` without `-e`. - The image assertion tested "not `unknown`", which an empty result also satisfies; it now asserts `free` or `busy`. **53 passed, 0 failed** on macOS `bash` 3.2 and Linux `bash` 5.2 against a real `ss`. The five implementation mutations each still fail it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
