bitflicker64 commented on PR #3119: URL: https://github.com/apache/hugegraph/pull/3119#issuecomment-5089359825
Unrelated to this change, but noticed while checking the `ServerOptions` table, so I left a `TODO` on it rather than silently fixing it here. The arthas options are declared camelCase (`arthas.telnetPort`, `arthas.httpPort`, `arthas.disabledCommands`) while `conf/rest-server.properties` ships them snake_case (`arthas.telnet_port`, `arthas.http_port`, `arthas.disabled_commands`). Nothing normalizes between the two, so those keys never match and `config.get()` returns the declared default. Only `arthas.ip` works. It is invisible today because each shipped value equals its default. It bites on any change, e.g. `arthas.disabled_commands=jad,exec` is dropped and `exec` stays enabled. Happy to send a separate PR renaming them to snake_case, which matches the rest of `ServerOptions` and the shipped file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
