imbajin commented on code in PR #3116:
URL: https://github.com/apache/hugegraph/pull/3116#discussion_r3652303865
##########
install-dist/scripts/dependency/known-dependencies.txt:
##########
@@ -44,8 +44,6 @@ byte-buddy-agent-1.10.5.jar
byte-buddy-agent-1.11.6.jar
caffeine-2.3.1.jar
caffeine-2.5.6.jar
Review Comment:
‼️ The dependency inventory was not fully regenerated after removing these
modules. The required `dependency-check` currently fails because dozens of
obsolete transitive JARs remain in this file, including `chronicle-*`,
`jffi`/`jnr`, `psjava`, and `zstd-jni`. Please run
`regenerate_known_dependencies.sh`, commit the complete result, and rerun the
dependency check.
##########
hugegraph-server/hugegraph-dist/pom.xml:
##########
@@ -66,6 +66,17 @@
<artifactId>hugegraph-rocksdb</artifactId>
<version>${revision}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.hugegraph</groupId>
+ <artifactId>hugegraph-hbase</artifactId>
Review Comment:
‼️ Moving HBase and HStore to unconditional dependencies breaks the
`rocksdb-only` distribution contract: the assembly copies all runtime
dependencies, while the `rocksdb-only` profile now only changes the backend
registry. Please keep these supported backends in a default-enabled profile
that is disabled by `-Drocksdb-only`.
##########
install-dist/release-docs/LICENSE:
##########
@@ -253,7 +253,6 @@ The text of each license is also included in
licenses/LICENSE-[project].txt.
https://central.sonatype.com/artifact/com.github.luben/zstd-jni/1.5.5-1 ->
BSD-2-Clause
Review Comment:
⚠️ Removing the backend modules also removes many transitive dependencies,
but their release metadata remains. For example, `zstd-jni-1.5.5-1`,
`chronicle-*`, `high-scale-lib`, `jnr-x86asm`, and `psjava` are absent from the
current reactor but remain in LICENSE/NOTICE or standalone license files.
Please prune these using the regenerated dependency inventory while retaining
components still used elsewhere.
##########
hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/cmd/InitStore.java:
##########
@@ -132,30 +119,21 @@ private static HugeGraph initGraph(String configPath)
throws Exception {
private static void initBackend(final HugeGraph graph)
throws InterruptedException {
int retries = RETRIES;
- retry:
- do {
+ while (true) {
try {
graph.initBackend();
} catch (Exception e) {
String clz = e.getClass().getSimpleName();
String message = e.getMessage();
- if (EXCEPTIONS.containsKey(clz) && retries > 0) {
- @SuppressWarnings("unchecked")
- Collection<String> keywords =
EXCEPTIONS.getCollection(clz);
- for (String keyword : keywords) {
- if (message.contains(keyword)) {
- LOG.info("Init failed with exception '{} : {}', " +
- "retry {}...",
- clz, message, RETRIES - retries + 1);
-
- Thread.sleep(RETRY_INTERVAL);
- continue retry;
- }
- }
+ if (retries-- > 0) {
Review Comment:
⚠️ This retries every initialization exception, so permanent configuration,
permission, or unsupported-operation failures now wait about 50 seconds before
surfacing and may repeat partially completed initialization. Please restrict
retries to explicitly transient backend failures and add a fail-fast test for
permanent errors.
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/config/CoreOptions.java:
##########
@@ -62,7 +62,7 @@ public class CoreOptions extends OptionHolder {
public static final ConfigOption<String> STORE =
new ConfigOption<>(
"store",
- "The database name like Cassandra Keyspace.",
+ "The backend database namespace.",
Review Comment:
🧹 Please apply the same cleanup to the active `hugegraph-struct`
counterparts: `options/CoreOptions.java` still mentions Cassandra at lines 50
and 70, while `query/Condition.java` and `backend/Shard.java` also retain
Cassandra-specific descriptions. These classes are used by Store modules, so
they are not archival documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
