Seanium commented on code in PR #3102:
URL: https://github.com/apache/hugegraph/pull/3102#discussion_r3636869445
##########
hugegraph-server/pom.xml:
##########
@@ -355,6 +347,24 @@
</build>
<profiles>
+ <profile>
+ <id>all-backends</id>
+ <activation>
+ <property>
+ <name>!rocksdb-only</name>
Review Comment:
Fixed on the current head. The new profiles in hugegraph-server/pom.xml and
hugegraph-test/pom.xml were removed, so the existing activeByDefault core-test
and memory profiles are no longer displaced. The default invocation was
rechecked with Maven and still activates memory, core-test, and the complete
module set; current-head org memory, RocksDB, and both macOS Server jobs have
also passed.
##########
hugegraph-server/hugegraph-dist/src/assembly/travis/run-api-test.sh:
##########
@@ -58,18 +58,60 @@ function download_to_dir() {
cd "$REPO_ROOT"
-VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
+ROCKSDB_ONLY=false
+
+if [[ "$BACKEND" == "rocksdb" &&
+ "$(uname -s)" == "Linux" &&
+ "$(uname -m)" == "riscv64" ]]; then
+ . "$TRAVIS_DIR/../static/bin/util.sh"
+ configure_riscv64_libatomic
+ ROCKSDB_ONLY=true
+fi
+
+if [[ "$ROCKSDB_ONLY" == "true" ]]; then
+ VERSION=$(mvn help:evaluate -Dexpression=project.version -q \
+ -DforceStdout -Drocksdb-only)
+else
+ VERSION=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)
+fi
SERVER_DIR=hugegraph-server/apache-hugegraph-server-$VERSION/
CONF=$SERVER_DIR/conf/graphs/hugegraph.properties
REST_SERVER_CONF=$SERVER_DIR/conf/rest-server.properties
GREMLIN_SERVER_CONF=$SERVER_DIR/conf/gremlin-server.yaml
JACOCO_PORT=36320
+SERVER_START_ATTEMPTED=false
+
+function cleanup() {
+ local status=$?
+ trap - EXIT
+
+ if [[ "$SERVER_START_ATTEMPTED" == "true" ]]; then
+ if ! "$TRAVIS_DIR"/stop-server.sh "$SERVER_DIR"; then
Review Comment:
Follow-up on the exact current head bd69efb8: the org RISC-V job initially
failed precisely because stop-hugegraph.sh propagated the 10-second shutdown
failure. Logs showed the Java shutdown hooks completed but the sleep-as-PID-1
container retained the exited daemon as a zombie. The CI container now uses
Docker --init to reap it; the product timeout and failure propagation remain
unchanged. Exact-head jobs 89152468612 and 89155333088 both then passed both
shutdowns and cleanup. This confirms the failure is not swallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
