contrueCT commented on PR #2994: URL: https://github.com/apache/hugegraph/pull/2994#issuecomment-5048558731
Thanks for checking the latest HStore failure. I traced the two reported errors separately: - `VertexCoreTest#testQueryByDateProperty` is the known HStore global range-ordering/cursor issue tracked in #3053. - `Undefined index label with id: '1228551733'` is separate from #3053 and aligns with the HStore schema/index lifecycle problems tracked in #3090. It is thrown while `BinarySerializer.readIndex()` deserializes a backend range-index entry and resolves its embedded index-label ID; the failing `doIndexQueryOnce()` read loop has no diff in this PR. The second failure is intermittent and state-dependent: the same test has failed with IDs `207`, `1228551550`, and `1228551733` in different runs, while run 29683719157 passed. This is consistent with either a stale HStore index row or schema-deletion/cache-propagation crossing test boundaries, rather than a deterministic regression in the ConditionQuery changes. The latest run did not upload the Surefire report or deeper diagnostics, so the current log cannot distinguish those two HStore sub-cases. I also don't plan to restore the earlier broad “skip undefined index-label rows” workaround: as noted in the previous review, a fully skipped backend page can make `PagingIdHolder` stop early and miss later valid rows. Would it be reasonable to treat these two failures as the tracked HStore issues in #3053 and #3090, outside the scope of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
