imbajin commented on code in PR #370:
URL: https://github.com/apache/hugegraph-ai/pull/370#discussion_r3608283255
##########
hugegraph-llm/src/hugegraph_llm/config/models/base_prompt_config.py:
##########
@@ -140,6 +141,7 @@ def to_literal(val):
"gremlin_generate_prompt":
to_literal(self.gremlin_generate_prompt),
"doc_input_text": to_literal(self.doc_input_text),
"graph_extract_split_type":
to_literal(self.graph_extract_split_type),
+ "graph_extract_max_workers": self.graph_extract_max_workers,
Review Comment:
⚠️ This adds `graph_extract_max_workers` to the persisted prompt
configuration, but the persistence tests still cover only
`graph_extract_split_type`: there is no round-trip assertion for a non-default
worker count and no old-YAML fixture without this key. A serialization or
upgrade-default regression could therefore silently reset the UI concurrency
setting while the new concurrency tests still pass. Please extend the
prompt-config tests to save/reload a non-default value and to load an older
config without this field, asserting the fallback remains `1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
