VGalaxies commented on code in PR #353: URL: https://github.com/apache/hugegraph-computer/pull/353#discussion_r3566237180
########## vermeer/Dockerfile: ########## @@ -14,14 +14,27 @@ # See the License for the specific language governing permissions and # limitations under the License. # -FROM golang:1.23-alpine AS builder +FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS builder +ARG TARGETOS Review Comment: ### ⚠️ Scope target arguments to the compilation step `TARGETOS` and `TARGETARCH` precede `apk add`, module download, UI download, and asset generation. The validation log executed each step separately for amd64 and arm64 (`#14`/`#15`, `#20`/`#21`, `#26`/`#27`, `#30`/`#31`). > [!WARNING] > Network-heavy downloads and asset generation scale with the number of target platforms, defeating target-neutral layer sharing. 🛠️ **Suggested change:** Move both `ARG` declarations immediately before the final `go build`, or put target-neutral preparation in a separate base stage. --- <sub>🤖 Codex review · **GPT-5.6 Sol** · effort: **max**</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
