VGalaxies commented on code in PR #3058:
URL: https://github.com/apache/hugegraph/pull/3058#discussion_r3400859373
##########
hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java:
##########
@@ -140,8 +139,6 @@ public class GraphTransaction extends IndexableTransaction {
private final int verticesCapacity;
private final int edgesCapacity;
Review Comment:
**Low: Protected listener state field was removed**
`hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/backend/tx/GraphTransaction.java:141`
**Evidence**
- The diff removes `protected static final ConcurrentHashMap<String,
Boolean> storeEventListenStatus` from `GraphTransaction`; `origin/master`
exposed it at old lines 143-144.
**Impact**
- External subclasses or same-package extensions compiled against this
protected member can fail to compile, and already-compiled code that references
the field can fail linkage after upgrade.
**Requested fix**
- Keep a deprecated compatibility field, or explicitly document this as a
breaking internal API change in the release notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
