imbajin commented on code in PR #3050:
URL: https://github.com/apache/hugegraph/pull/3050#discussion_r3360277066
##########
hugegraph-server/hugegraph-dist/pom.xml:
##########
@@ -123,6 +124,15 @@
<artifactId>grpc-stub</artifactId>
<version>${grpc.version}</version>
</dependency>
+
+ <!-- Added updated jar to avoid java.lang.NoClassDefFoundError:
org/fusesource/jansi/AnsiConsole when launching
+ gremlin console on arm64 -->
+ <dependency>
Review Comment:
⚠️ **Add a distro regression check**
Evidence: the fix is purely in distro packaging, so the normal unit/core/api
suites do not exercise the `gremlin-console.sh` classpath. I could not find an
automated check that launches the packaged console or at least asserts the
tarball contains `lib/jansi-*.jar`.
Impact: this exact classpath regression can silently return after a
dependency or assembly change and only be caught by users starting the packaged
console.
Requested fix: add a distro-level smoke check, for example launching
`bin/gremlin-console.sh -- -e <script>` from the assembled server, or at
minimum asserting the packaged archive contains the Jansi jar.
##########
install-dist/release-docs/licenses/LICENSE-jansi-2.4.0.txt:
##########
@@ -0,0 +1,16 @@
+Copyright (c) 2007-2021, the original author(s)
Review Comment:
‼️ **Vendor the full license text**
Evidence: this new file is a 16-line summary with URLs, but the surrounding
`install-dist/release-docs/licenses/LICENSE-*.txt` files vendor complete
upstream license texts. The new `LICENSE` entry also points readers here for
license details, which this summary does not provide.
Impact: the release docs for the newly bundled jar are incomplete, which is
an ASF release/legal risk even if the runtime dependency is correct.
Requested fix: replace this file with the full upstream license text for the
license option HugeGraph is relying on for distribution, and align the
`LICENSE`/`NOTICE` wording with that choice.
##########
hugegraph-server/hugegraph-dist/pom.xml:
##########
@@ -123,6 +124,15 @@
<artifactId>grpc-stub</artifactId>
<version>${grpc.version}</version>
</dependency>
+
+ <!-- Added updated jar to avoid java.lang.NoClassDefFoundError:
org/fusesource/jansi/AnsiConsole when launching
+ gremlin console on arm64 -->
+ <dependency>
Review Comment:
‼️ **Update the known dependency inventory**
Evidence: this PR adds `org.fusesource.jansi:jansi:2.4.0`, and the
dependency-check job diffs the generated inventory with
`install-dist/scripts/dependency/known-dependencies.txt`; the failed job shows
`+jansi-2.4.0.jar`, while the tracked file has no such entry.
Impact: the release dependency gate will keep failing for this PR, and the
newly bundled jar is not recorded in the deterministic dependency inventory.
Requested fix: regenerate and commit
`install-dist/scripts/dependency/known-dependencies.txt`, or add the missing
`jansi-2.4.0.jar` entry in the correct sorted position.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
