imbajin commented on code in PR #734:
URL:
https://github.com/apache/hugegraph-toolchain/pull/734#discussion_r3185973256
##########
hugegraph-loader/src/main/java/org/apache/hugegraph/loader/util/DateUtil.java:
##########
@@ -18,16 +18,15 @@
package org.apache.hugegraph.loader.util;
import java.util.Date;
-import java.util.Map;
import java.util.TimeZone;
-import java.util.concurrent.ConcurrentHashMap;
import org.apache.hugegraph.date.SafeDateFormat;
import org.apache.hugegraph.loader.constant.Constants;
public final class DateUtil {
- private static final Map<String, SafeDateFormat> DATE_FORMATS = new
ConcurrentHashMap<>();
+ private static final ThreadLocal<java.util.HashMap<String,
SafeDateFormat>> DATE_FORMATS =
Review Comment:
⚠️ Please avoid using fully-qualified JDK type names inline here. There is
no naming conflict in this file, so `java.util.HashMap` should be imported and
referenced as `HashMap` instead. The same applies to the method reference
below. Keeping the fully-qualified name in the declaration makes the code
harder to read and goes against the project's Java style conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
