vbhanuchander-lang commented on PR #8254: URL: https://github.com/apache/hop/pull/8254#issuecomment-5533564338
Thanks @mattcasters, and thanks for pushing the changes rather than sending them back — all three are improvements. The trailing backslash is a real miss on my part: `partitionFolder` only checked for `/`, so a base path typed with a Windows separator would have produced a double separator before the first `name=value` level. Good catch, and your test pins it. On Lombok: I hand-wrote the accessors to match `ParquetField` next door, which still has them expanded. Happy to follow the Lombok convention — worth a separate sweep for the older classes in this package at some point, but not in this PR. Pulled your commit and re-ran locally: the full module run is **48 tests, 0 failures** (17 in `ParquetOutputPartitionTest` now, with your new one), and `Hop PR Build (Code)` is green on `b6c5a79`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
