mattcasters commented on PR #8242: URL: https://github.com/apache/hop/pull/8242#issuecomment-5515628645
Thanks for the investigation — the round-trip failure is real (#8216). This PR cannot land as written against current main. `numericLength()` is documented as **digits before the decimal** and dialect rules already depend on that (MySQL overscaled DOUBLE, PostgreSQL DOUBLE/NUMERIC, Oracle NUMBER(38)). Redefining it to JDBC precision would change those conditions. #8216 is fixed in mattcasters/hop#issue-8218 / the follow-up PR on apache/hop by: - keeping `numericLength()` as integer digits for rule conditions - storing JDBC precision as Hop Number length (`totalDigits()`) - changing PostgreSQL write from `NUMERIC(length + scale, scale)` to `NUMERIC(length, scale)` so it does not inflate once length is total digits again Please close this PR in favour of that one once it is up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
