mattcasters opened a new pull request, #8244: URL: https://github.com/apache/hop/pull/8244
Verified against **current main / 2.20 type rules**, not 2.19 `getFieldDefinition`. That is the answer to the review notes on #8220 / #8221. ## Already handled by #8214 (Database perspective) These are **not** in this PR. Comments are on the issues; they should close when #8214 merges: - #8224 query timeout on DDL/DML - #8228 cancel-watcher leak in Hop Web - #8229 SQL editor 1000-row cap is client-side only #8217 was already closed (UNIQUEIDENTIFIER on both SQL Server dialects). ## This PR | Issue | Change | |---|---| | #8216 | Hop Number length is JDBC precision (total digits). `numericLength()` stays integer digits for dialect rule conditions. PostgreSQL writes `NUMERIC(length, scale)` so it round-trips. Does **not** merge #8242 as-is (that inverts `numericLength()` and would inflate Postgres precision). | | #8218 | Timestamp parse mask reads `HOP_DEFAULT_TIMESTAMP_FORMAT` | | #8219 | Stream Lookup Timestamp default no longer throws `ConversionNotImplemented` | | #8220 | SQL Server `DATE` / `TIME` / `DATETIME2` via type rules; new Date fields stay `DATETIME` | | #8221 | SQL Server `NVARCHAR`/`NCHAR` preserved; `TEXT` replaced with `VARCHAR(MAX)` | | #8222 | Parameter metadata goes through `StandardJdbcTypeMapper` (`NVARCHAR`, `NUMERIC(p,s)`) | | #8223 | Ordinary JDBC no longer calls the data-service `getColumns()` path | | #8225 | Empty leftover metadata folders are not listed under Unknown | | #8226 | `catalog.schema` is split even when `supportsCatalogs()` is false | | #8227 | `ProgressMonitorDialog` disposes when the runnable returns (Get fields no longer hangs) | | #8230 | Dead View-menu terminal constants and unused `USE_ADVANCED_TERMINAL` key removed | ## Tests Focused modules run under `tools/with-isolated-display.sh`: core, ui, mssql, mssqlnative, postgresql (+ redshift/greenplum/cockroach), mysql, oracle, streamlookup. Fixes #8216 #8218 #8219 #8220 #8221 #8222 #8223 #8225 #8226 #8227 #8230 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
