mattcasters opened a new pull request, #8186: URL: https://github.com/apache/hop/pull/8186
JSON Input still failed when Content tab **Do not raise an error if no files** was checked, and could also log `No file(s) specified! Stop processing.` for listed files that were present (Required Y/N did not change that). The checkbox only guarded the empty `FileInputList` in `prepareToRowProcessing`; `onNewFile()` treated a missing/invalid path as an error with no regard for the option. This honors the flag in `onNewFile`: a missing file is skipped (same iterator path as ignore-empty-file) instead of incrementing errors. The empty-list check already resolves `getFileInputList` first (so existing files no longer look like "no files"). Other Content-tab flags (ignore empty file, ignore missing JSON path, default path leaf to null, row limit, extra file fields) were already wired; no further mismatches there. Tests in `JsonInputTest` cover issue comment A/C/E, invalid path with the checkbox on, and `onNewFile` missing-file skip vs fail. fixes #2723 ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
