vbhanuchander-lang commented on code in PR #7860:
URL: https://github.com/apache/hop/pull/7860#discussion_r3754066638
##########
lib/pom.xml:
##########
@@ -228,6 +231,21 @@
<artifactId>ST4</artifactId>
<version>${ST4.version}</version>
</dependency>
+ <dependency>
+ <groupId>jakarta.jms</groupId>
+ <artifactId>jakarta.jms-api</artifactId>
+ <version>${jakarta-jms-api.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jakarta-client</artifactId>
+ <version>${artemis-jakarta-client.version}</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-server</artifactId>
+ <version>${artemis-server.version}</version>
+ </dependency>
Review Comment:
Thank you — fixed in bffe7c7. Moved both the client and the test-scoped
embedded server to `org.apache.artemis`, and to 2.55.0.
I checked what the move actually affects before assuming: only the Maven
coordinates changed, not the Java packages. The reflective factory lookup still
resolves `org.apache.activemq.artemis.jms.client.ActiveMQJMSConnectionFactory`
on 2.55.0, and the embedded-broker test still starts a real broker and
round-trips a message, so no source change was needed. All 18 tests pass and
the plugin zip packages only the 2.55.0 jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
