mattcasters opened a new pull request, #7853:
URL: https://github.com/apache/hop/pull/7853

   ## What
   
   Fixes arrow (and Home/End/Page Up/Down) keys not moving the caret in Hop Web 
text fields. Shift+arrow already worked.
   
   ## Why
   
   Canvas pan shortcuts on bare arrow keys (`DragViewZoomBase`) were registered 
as RAP `CANCEL_KEYS`. That calls `preventDefault` in the browser for those keys 
globally, so text fields never get native caret movement.
   
   ## How
   
   1. **`HopWebEntryPoint`**: keep bare navigation keys in `ACTIVE_KEYS` 
(canvas pan still reaches the server when the graph has focus) but exclude them 
from `CANCEL_KEYS`, same pattern as Ctrl+C/V/X.
   2. **`HopGuiKeyHandler`**: when focus is in Text/Combo/CCombo/StyledText, 
leave bare navigation keys (and Shift+arrow selection) to the widget so canvas 
pan does not fire while editing. Ctrl/Cmd/Alt combos still work.
   
   ## Testing
   
   - Unit: `HopWebEntryPointTest` (including new navigation-key case)
   - Manual: verified caret movement and Shift+selection in Hop Web text 
fields; canvas arrow pan still works when the graph has focus
   
   Fixes #7833


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to