mattcasters opened a new pull request, #7809:
URL: https://github.com/apache/hop/pull/7809

   ## Summary
   
   Implements [issue #3165](https://github.com/apache/hop/issues/3165): add 
**Workflow from field?** / **Workflow field** to the Workflow Executor 
transform, matching the existing Pipeline Executor capability.
   
   Reviewers can focus on:
   
   1. **Runtime parity with Pipeline Executor**
      - New meta properties: `filenameInField`, `filenameField` (XML keys 
aligned with Pipeline Executor).
      - Static path still loads in `init()`; from-field defers load until 
`processRow()`.
      - Path changes flush a partial size-group, reload the child workflow, and 
do **not** write into shared transform meta (`runtimeWorkflowFilename` / 
`prevFilename` on data) so multi-copy stays isolated.
      - `loadWorkflowMeta(...)` gains an explicit-filename overload for that 
runtime path.
   
   2. **GUI**
      - Checkbox + field combo between path and run configuration.
      - Path/browse disabled when from-field is selected; `ok()` skips static 
workflow load validation in that mode.
   
   3. **Tests / docs**
      - Unit tests for serialization, defaults, init (static missing / 
from-field / filesystem load / explicit path).
      - Integration: `main-0083-workflow-executor-test.hwf` now also runs 
`0083-workflow-executor-fromfield.hpl` (two different child workflows from a 
stream field; expects 2 execution-result rows).
      - User manual options updated for the new controls.
   
   ### Backward compatibility
   
   Defaults keep existing pipelines unchanged (`filenameInField=false`). Static 
filename behavior is preserved.
   
   ## Test plan
   
   - [x] `./mvnw -pl plugins/transforms/workflowexecutor -am test 
-Dtest=WorkflowExecutorMetaTest,WorkflowExecutorTest`
   - [x] Ran `main-0083-workflow-executor-test.hwf` via hop-run (static + 
from-field paths both succeeded)
   - [ ] Spot check dialog: toggle **Workflow from field**, save/reload, 
confirm `filenameInField` / `filenameField` in XML
   - [ ] CI transforms integration-tests project


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to