mattcasters opened a new pull request, #7366:
URL: https://github.com/apache/hop/pull/7366

   ### Description
   This change introduces a tabbed interface (`CTabFolder`) to the **Delete** 
transform dialog (`DeleteDialog`). 
   
   Previously, all widgets (connection settings, commit configurations, and key 
lookup tables) were rendered on a single layout panel. Under Linux (especially 
GTK/Wayland environments or with display scaling enabled, e.g., 
`GDK_SCALE=1.5`), this squashed the table view grids, making them unresizable 
and difficult to interact with (as reported in issue #7188). 
   
   Adding a tabbed interface allows the grid controls to take up sufficient 
vertical height, resolving UI accessibility issues and aligning the Delete 
dialog with related transform dialogs (such as *Update* and *Insert/Update*).
   
   ### Changes
   * **DeleteDialog UI**:
     * Migrated the layout from a single composite parented by the main dialog 
shell to a `CTabFolder` component.
     * Split dialog controls into two tabs:
       1. **General**: Target database connection, schema, table, commit size, 
and batch delete settings.
       2. **Lookup Keys**: Key comparison grid and the "Get fields" button.
     * Cleaned up hardcoded button layouts by using the standard 
`setButtonPositions(...)` helper.
   * **Translation Files**:
     * Added `DeleteDialog.GeneralTab.Title` and `DeleteDialog.KeysTab.Title` 
translation keys to `messages_en_US.properties` and `messages_pt_BR.properties`.
   
   ### Verification & Testing
   * Code has been formatted using Spotless (`mvn spotless:apply`).
   * Validated full project compilation and client assembly via:
     ```bash
     ./mvnw -T5 -Pfast-build clean install
     ```
     (Build succeeded with no errors).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to