xdelox commented on code in PR #4784:
URL: https://github.com/apache/hop/pull/4784#discussion_r1917019917
##########
plugins/transforms/tableinput/src/main/java/org/apache/hop/pipeline/transforms/tableinput/TableInputDialog.java:
##########
@@ -377,22 +388,27 @@ private List<String> getSqlReservedWords() {
databaseMetaData = db.getDatabaseMetaData();
if (databaseMetaData == null) {
logError("Couldn't get database metadata");
- return new ArrayList<>();
+ return;
}
List<String> sqlKeywords = new ArrayList<>();
try {
final ResultSet functionsResultSet =
databaseMetaData.getFunctions(null, null, null);
while (functionsResultSet.next()) {
- sqlKeywords.add(functionsResultSet.getString("FUNCTION_NAME"));
+ String functionName = functionsResultSet.getString("FUNCTION_NAME");
+ if (functionName.contains(";")) {
+ functionName = functionName.substring(0,
functionName.indexOf(";"));
Review Comment:
this string replacement is here because of MS SQL Server: in fact, the
`getFunctions()` method returns functions with something more. Like, if the
function name is `helloworld()`, it returns `helloworld;1`, so we have to
remove the substring from the semicolon on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
