sramazzina opened a new pull request, #2897: URL: https://github.com/apache/hop/pull/2897
fix #2883 Workflow executor: do not fire consistency check in case there are no result from sub-workflows I decided it was a better idea to relax the constraints to not block the execution in case a field in the result stream was missing. This is because if that missing field(s) come from a sub-pipeline respectively called by the workflow's executor sub-workflow, that behavior could be unwanted in case the sub-pipeline does not return any rows (and so any new fields respect to the input result row). I think it would be a good idea to add a flag to re-enable the raise of an exception in case a field of the required results fields list is missing from the results fields list to support certain use-cases. Feel free to add an issue to request this and I will be more than happy to do that. Therefore, currently, the exception will be raised only if there's a difference in datatypes, same as in the original version but now more clean and complete. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`. - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
