[ https://issues.apache.org/jira/browse/HIVE-18246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285803#comment-16285803 ]
Hive QA commented on HIVE-18246: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12901427/HIVE-18246.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11516 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=160) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat] (batchId=178) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[subquery_multi] (batchId=113) org.apache.hadoop.hive.cli.TestSparkPerfCliDriver.testCliDriver[query39] (batchId=248) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=226) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8176/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8176/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8176/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12901427 - PreCommit-HIVE-Build > Replace toString with getExprString in > AbstractOperatorDesc::getColumnExprMapForExplain > --------------------------------------------------------------------------------------- > > Key: HIVE-18246 > URL: https://issues.apache.org/jira/browse/HIVE-18246 > Project: Hive > Issue Type: Improvement > Reporter: Vineet Garg > Assignee: Vineet Garg > Attachments: HIVE-18246.1.patch, HIVE-18246.2.patch > > > AbstractOperatorDesc::getColumnExprMapForExplain uses toString on ExprNode to > get the string representation of an expr. getExprString is better suited here > since each ExprNode class has suitable implementation for this. -- This message was sent by Atlassian JIRA (v6.4.14#64029)