[ https://issues.apache.org/jira/browse/HIVE-18141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16265329#comment-16265329 ]
Hive QA commented on HIVE-18141: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12899097/HIVE-18141.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 11412 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_range_multiorder] (batchId=7) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2] (batchId=154) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=157) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=224) org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=230) org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=230) org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=230) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7995/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7995/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7995/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 8 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12899097 - PreCommit-HIVE-Build > Fix StatsUtils.combineRange to combine intervals > ------------------------------------------------ > > Key: HIVE-18141 > URL: https://issues.apache.org/jira/browse/HIVE-18141 > Project: Hive > Issue Type: Sub-task > Components: Statistics > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Attachments: HIVE-18141.01.patch, HIVE-18141.02.patch > > > the current [combinedRange > implementation|https://github.com/apache/hive/blob/d9924ab3e285536f7e2cc15ecbea36a78c59c66d/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java#L1984] > in its current form "combines" only ranges which contain eachother > but the comments suggests that the intention was to capture the case when the > 2 intervals are overlap; can be checked with the following testcase: > {code} > @Test > public void test11() { > Range r1 = new Range(0, 1); > Range r2 = new Range(1, 11); > Range r3 = StatsUtils.combineRange(r1, r2); > assertNotNull(r3); > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)