[ https://issues.apache.org/jira/browse/HIVE-16756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254295#comment-16254295 ]
Vihang Karajgaonkar commented on HIVE-16756: -------------------------------------------- Actually, after discussing with [~aihuaxu] I realized that {{LongColDivideLongColumn.java}} doesn't need the fix since it typecasts the denominator to double. So it should not throw a / by zero exception. For the other cases of division and modulo when one of the operands is double, the result is a double so that should work fine too. I guess we should only hit this issue when we have a long modulo long. Is that understanding correct [~mmccline]? If yes, I can modify the patch such that it doesn't generate a LongColModuloLongColumn.java but rather we add it to source code after handling the / by zero. > Vectorization: LongColModuloLongColumn throws "java.lang.ArithmeticException: > / by zero" > ---------------------------------------------------------------------------------------- > > Key: HIVE-16756 > URL: https://issues.apache.org/jira/browse/HIVE-16756 > Project: Hive > Issue Type: Bug > Components: Hive > Affects Versions: 2.3.0 > Reporter: Matt McCline > Assignee: Vihang Karajgaonkar > Priority: Critical > Attachments: HIVE-16756.01.patch > > > vectorization_div0.q needs to test the long data type testing. -- This message was sent by Atlassian JIRA (v6.4.14#64029)