[ https://issues.apache.org/jira/browse/HIVE-17911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16239662#comment-16239662 ]
Hive QA commented on HIVE-17911: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12896133/HIVE-17911.3.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7654/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7654/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7654/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2017-11-05 18:03:40.725 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-7654/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2017-11-05 18:03:40.728 + cd apache-github-source-source + git fetch origin >From https://github.com/apache/hive 6c87136..49f6814 master -> origin/master + git reset --hard HEAD HEAD is now at 6c87136 HIVE-17932 : Remove option to control partition level basic stats fetching (Zoltan Haindrich via Ashutosh Chauhan) + git clean -f -d + git checkout master Already on 'master' Your branch is behind 'origin/master' by 1 commit, and can be fast-forwarded. (use "git pull" to update your local branch) + git reset --hard origin/master HEAD is now at 49f6814 HIVE-17962 : org.apache.hadoop.hive.metastore.security.MemoryTokenStore - Parameterize Logging (Beluga Behr via Aihua Xu) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2017-11-05 18:03:46.226 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Going to apply patch with: patch -p1 patching file standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java Hunk #2 succeeded at 218 (offset -3 lines). Hunk #3 succeeded at 247 (offset -3 lines). Hunk #4 succeeded at 337 (offset -3 lines). Hunk #5 succeeded at 384 (offset -3 lines). Hunk #6 succeeded at 455 (offset -3 lines). Hunk #7 succeeded at 520 (offset -3 lines). Hunk #8 succeeded at 539 (offset -3 lines). Hunk #9 succeeded at 568 (offset -3 lines). Hunk #10 succeeded at 579 (offset -3 lines). Hunk #11 succeeded at 631 (offset -3 lines). Hunk #12 succeeded at 661 (offset -3 lines). Hunk #13 succeeded at 828 (offset -3 lines). Hunk #14 succeeded at 867 (offset -3 lines). Hunk #15 succeeded at 913 (offset -3 lines). Hunk #16 succeeded at 924 (offset -3 lines). Hunk #17 succeeded at 1072 (offset -3 lines). Hunk #18 succeeded at 1180 (offset -3 lines). Hunk #19 succeeded at 1379 (offset -3 lines). Hunk #20 succeeded at 1505 (offset -3 lines). Hunk #21 succeeded at 1847 (offset -3 lines). Hunk #22 succeeded at 1970 (offset -3 lines). Hunk #23 succeeded at 2028 (offset -3 lines). Hunk #24 succeeded at 2133 (offset -3 lines). Hunk #25 succeeded at 2185 (offset -3 lines). Hunk #26 succeeded at 2193 (offset -3 lines). Hunk #27 succeeded at 2258 (offset -3 lines). Hunk #28 succeeded at 2408 (offset -3 lines). Hunk #29 succeeded at 2432 (offset -3 lines). Hunk #30 succeeded at 2440 (offset -3 lines). Hunk #31 succeeded at 2469 (offset -3 lines). Hunk #32 succeeded at 2514 (offset -3 lines). Hunk #33 succeeded at 2536 (offset -3 lines). Hunk #34 succeeded at 2681 (offset -3 lines). Hunk #35 succeeded at 2763 (offset -3 lines). Hunk #36 succeeded at 2861 (offset -3 lines). Hunk #37 succeeded at 2935 (offset -3 lines). Hunk #38 succeeded at 2959 (offset -3 lines). Hunk #39 succeeded at 2998 (offset -3 lines). Hunk #40 succeeded at 3009 (offset -3 lines). Hunk #41 succeeded at 3259 (offset -3 lines). Hunk #42 succeeded at 3339 (offset -3 lines). Hunk #43 succeeded at 3395 (offset -3 lines). Hunk #44 succeeded at 3427 (offset -3 lines). Hunk #45 succeeded at 3450 (offset -3 lines). Hunk #46 succeeded at 3475 (offset -3 lines). Hunk #47 succeeded at 3527 (offset -3 lines). Hunk #48 succeeded at 3831 (offset -3 lines). Hunk #49 succeeded at 3871 (offset -3 lines). Hunk #50 succeeded at 3907 (offset -3 lines). Hunk #51 succeeded at 3915 (offset -3 lines). Hunk #52 succeeded at 3930 (offset -3 lines). Hunk #53 succeeded at 4631 (offset -3 lines). Hunk #54 succeeded at 4889 (offset -3 lines). Hunk #55 succeeded at 4902 (offset -3 lines). Hunk #56 succeeded at 4937 (offset -3 lines). Hunk #57 succeeded at 4969 (offset -3 lines). Hunk #58 succeeded at 4978 (offset -3 lines). Hunk #59 succeeded at 5012 (offset -3 lines). Hunk #60 succeeded at 5021 (offset -3 lines). Hunk #61 succeeded at 5055 (offset -3 lines). Hunk #62 succeeded at 5064 (offset -3 lines). Hunk #63 succeeded at 5100 (offset -3 lines). Hunk #64 succeeded at 5109 (offset -3 lines). Hunk #65 succeeded at 5137 (offset -3 lines). Hunk #66 succeeded at 5166 (offset -3 lines). Hunk #67 succeeded at 5193 (offset -3 lines). Hunk #68 succeeded at 5208 (offset -3 lines). Hunk #69 succeeded at 5234 (offset -3 lines). Hunk #70 succeeded at 5426 (offset -3 lines). Hunk #71 succeeded at 5449 (offset -3 lines). Hunk #72 succeeded at 5665 (offset -3 lines). Hunk #73 succeeded at 5763 (offset -3 lines). Hunk #74 succeeded at 5845 (offset -3 lines). Hunk #75 succeeded at 6203 (offset -3 lines). Hunk #76 succeeded at 6331 (offset -3 lines). Hunk #77 succeeded at 6391 (offset -3 lines). Hunk #78 succeeded at 6842 (offset -3 lines). Hunk #79 succeeded at 7382 (offset -3 lines). Hunk #80 succeeded at 7585 (offset -3 lines). Hunk #81 succeeded at 7671 (offset -3 lines). Hunk #82 succeeded at 7881 (offset -3 lines). Hunk #83 succeeded at 7958 (offset -3 lines). Hunk #84 succeeded at 8074 (offset -3 lines). Hunk #85 succeeded at 8096 (offset -3 lines). Hunk #86 succeeded at 8118 (offset -3 lines). Hunk #87 succeeded at 8141 (offset -3 lines). Hunk #88 succeeded at 8160 (offset -3 lines). Hunk #89 succeeded at 8187 (offset -3 lines). Hunk #90 succeeded at 8215 (offset -3 lines). Hunk #91 succeeded at 8238 (offset -3 lines). Hunk #92 succeeded at 8272 (offset -3 lines). Hunk #93 succeeded at 8290 (offset -3 lines). Hunk #94 succeeded at 8361 (offset -3 lines). Hunk #95 succeeded at 8398 (offset -3 lines). Hunk #96 succeeded at 8452 (offset -3 lines). Hunk #97 succeeded at 8714 (offset -3 lines). Hunk #98 succeeded at 8754 (offset -3 lines). Hunk #99 succeeded at 8786 (offset -3 lines). Hunk #100 succeeded at 8804 (offset -3 lines). Hunk #101 succeeded at 8966 (offset -3 lines). Hunk #102 succeeded at 8977 (offset -3 lines). Hunk #103 succeeded at 9359 (offset -3 lines). + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven protoc-jar: protoc version: 250, detected platform: linux/amd64 protoc-jar: executing: [/tmp/protoc939467304186016744.exe, -I/data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/protobuf/org/apache/hadoop/hive/metastore, --java_out=/data/hiveptest/working/apache-github-source-source/standalone-metastore/target/generated-sources, /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/protobuf/org/apache/hadoop/hive/metastore/metastore.proto] ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/standalone-metastore/target/generated-sources/org/apache/hadoop/hive/metastore/parser/FilterParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/parser/Filter.g org/apache/hadoop/hive/metastore/parser/Filter.g [ERROR] COMPILATION ERROR : [ERROR] /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:[3263,86] ')' expected [ERROR] /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:[3399,86] ')' expected [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.5.1:compile (default-compile) on project hive-standalone-metastore: Compilation failure: Compilation failure: [ERROR] /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:[3263,86] ')' expected [ERROR] /data/hiveptest/working/apache-github-source-source/standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java:[3399,86] ')' expected [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hive-standalone-metastore + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12896133 - PreCommit-HIVE-Build > org.apache.hadoop.hive.metastore.ObjectStore - Tune Up > ------------------------------------------------------ > > Key: HIVE-17911 > URL: https://issues.apache.org/jira/browse/HIVE-17911 > Project: Hive > Issue Type: Improvement > Components: Hive > Affects Versions: 3.0.0 > Reporter: BELUGA BEHR > Assignee: BELUGA BEHR > Priority: Minor > Attachments: HIVE-17911.1.patch, HIVE-17911.2.patch, > HIVE-17911.3.patch > > > # Remove unused variables > # Add logging parameterization > # Use CollectionUtils.isEmpty/isNotEmpty to simplify and unify collection > empty check (and always use null check) > # Minor tweaks -- This message was sent by Atlassian JIRA (v6.4.14#64029)