[ https://issues.apache.org/jira/browse/HIVE-17402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16198986#comment-16198986 ]
Dan Burkert commented on HIVE-17402: ------------------------------------ This patch is adding the location parameter to the [hcatalog notification message classes|https://github.com/apache/hive/tree/master/hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/messaging/json], which were deprecated as part of [HIVE-15180|https://issues.apache.org/jira/browse/HIVE-15180?focusedCommentId=15682862&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15682862]. The replacement [metastore notification message classes|https://github.com/apache/hive/tree/master/metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json] in many cases include a serialized full {{Table}} object, which internally includes the location URI, so adding the location parameters should not be necessary if Sentry switches over to use the new notification event classes. This patch, as I understand it, will not have the intended effect of adding the location URI to notification log entries, since the modified classes are no longer used in the HMS. > Provide object location in the HMS notification messages > -------------------------------------------------------- > > Key: HIVE-17402 > URL: https://issues.apache.org/jira/browse/HIVE-17402 > Project: Hive > Issue Type: Improvement > Components: Hive > Affects Versions: 2.2.0 > Reporter: Alexander Kolbasov > Assignee: Alexander Kolbasov > Attachments: HIVE-17402.01.patch > > > While working on the Apache Sentry project that uses HMS notifications we > noticed that these notifications are using some useful data - e.g. location > information for the objects. To get around these, ApacheSentry implemented > its own version of events > (https://github.com/apache/sentry/tree/master/sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json). > It seems to be a useful information for Hive as well, so why not add it > directly into the standard message factory? -- This message was sent by Atlassian JIRA (v6.4.14#64029)