[ https://issues.apache.org/jira/browse/HIVE-17544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188899#comment-16188899 ]
Hive QA commented on HIVE-17544: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12890005/HIVE-17544.3.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 11193 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_predicate_pushdown] (batchId=232) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert] (batchId=232) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[optimize_nullscan] (batchId=162) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=157) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=171) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query14] (batchId=240) org.apache.hadoop.hive.cli.control.TestDanglingQOuts.checkDanglingQOut (batchId=203) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/7075/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/7075/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-7075/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12890005 - PreCommit-HIVE-Build > Provide classname info for function authorization > ------------------------------------------------- > > Key: HIVE-17544 > URL: https://issues.apache.org/jira/browse/HIVE-17544 > Project: Hive > Issue Type: Task > Components: Authorization > Affects Versions: 2.1.1 > Reporter: Na Li > Assignee: Aihua Xu > Priority: Critical > Attachments: HIVE-17544.1.patch, HIVE-17544.2.patch, > HIVE-17544.3.patch > > > Right now, for authorization 2, the > HiveAuthorizationValidator.checkPrivileges(HiveOperationType var1, > List<HivePrivilegeObject> var2, List<HivePrivilegeObject> var3, > HiveAuthzContext var4) does not contain the parsed sql command string as > input. Therefore, Sentry has to parse the command again. > The API should be changed to include all required information as input, so > Sentry does not need to parse the sql command string again. > known situations: > 1) when dropping a database which does not exist, hive should not call sentry > or it calls sentry with database name as input > 2) when creating function, hive should provide UDF class name as input. > 3) When dropping function, hive should provide UDF class name as input. > 4) When dropping a table which does not exist, hive should not call sentry or > it calls sentry with database name and table name as input. > 5) In any situation that the command should succeeds and hive does not > provide required info to sentry, hive should not call sentry at all because > sentry will throw exception when required info is not available from input. -- This message was sent by Atlassian JIRA (v6.4.14#64029)