[ https://issues.apache.org/jira/browse/HIVE-17510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173530#comment-16173530 ]
Hive QA commented on HIVE-17510: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12888005/HIVE-17510.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 14 failed/errored test(s), 11044 tests executed *Failed tests:* {noformat} TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=230) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[materialized_view_create_rewrite] (batchId=239) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[smb_mapjoin_10] (batchId=239) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_view] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_hash] (batchId=28) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[unionDistinct_1] (batchId=143) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=156) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_explainuser_1] (batchId=170) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[drop_table_failure2] (batchId=89) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=234) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=234) org.apache.hadoop.hive.ql.TestAcidOnTez.testCtasTezUnion (batchId=215) org.apache.hadoop.hive.ql.TestAcidOnTez.testNonStandardConversion01 (batchId=215) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6905/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6905/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6905/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 14 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12888005 - PreCommit-HIVE-Build > Make comparison of filter predicates in q files deterministic > ------------------------------------------------------------- > > Key: HIVE-17510 > URL: https://issues.apache.org/jira/browse/HIVE-17510 > Project: Hive > Issue Type: Bug > Components: Testing Infrastructure > Affects Versions: 3.0.0 > Reporter: Jesus Camacho Rodriguez > Assignee: Jesus Camacho Rodriguez > Attachments: HIVE-17510.01.patch, HIVE-17510.patch > > > I have been hitting this issue while submitting patches to test HIVE-17432. > Basically, the order on which the rewriting might create the children of AND > operations is not deterministic. Thus, tests might fail because the created > golden file is not the same, thought the test should pass because they just > simply do not follow same order: > {code} > predicate: ((d_year >= 1992) and (d_year <= 1997) and ((c_city = 'UNITED > KI1') or (c_city = 'UNITED KI5')) and ((s_city = 'UNITED KI1') or (s_city = > 'UNITED KI5'))) (type: boolean) > {code} > {code} > predicate: ((d_year <= 1997) and (d_year >= 1992) and ((c_city = 'UNITED > KI1') or (c_city = 'UNITED KI5')) and ((s_city = 'UNITED KI1') or (s_city = > 'UNITED KI5'))) (type: boolean) > {code} > This patches fixes the issue by sorting the children of some expressions > (currently AND and OR children) when we run explain plan and we are running > in test mode. -- This message was sent by Atlassian JIRA (v6.4.14#64029)