[ https://issues.apache.org/jira/browse/HIVE-17536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167949#comment-16167949 ]
Hive QA commented on HIVE-17536: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12887195/HIVE-17536.1.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 56 failed/errored test(s), 11040 tests executed *Failed tests:* {noformat} TestAccumuloCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=230) TestDummy - did not produce a TEST-*.xml file (likely timed out) (batchId=230) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[select_dummy_source] (batchId=239) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[annotate_stats_table] (batchId=20) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[concat_op] (batchId=71) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[create_view] (batchId=39) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[decimal_precision2] (batchId=50) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_into1] (batchId=21) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[select_dummy_source] (batchId=22) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[stats9] (batchId=26) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamp_literal] (batchId=26) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[timestamptz] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_add_months] (batchId=61) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_aes_decrypt] (batchId=52) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_aes_encrypt] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_bitwise_shiftleft] (batchId=19) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_bitwise_shiftright] (batchId=74) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_bitwise_shiftrightunsigned] (batchId=28) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_cbrt] (batchId=79) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_crc32] (batchId=2) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_current_database] (batchId=64) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_date_format] (batchId=55) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_decode] (batchId=82) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_factorial] (batchId=81) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_from_utc_timestamp] (batchId=80) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_last_day] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_levenshtein] (batchId=29) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask] (batchId=72) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_first_n] (batchId=74) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_hash] (batchId=28) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_last_n] (batchId=36) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_show_first_n] (batchId=4) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_mask_show_last_n] (batchId=54) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_md5] (batchId=9) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_months_between] (batchId=51) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_nullif] (batchId=81) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_quarter] (batchId=43) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sha1] (batchId=7) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_sha2] (batchId=11) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_soundex] (batchId=36) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_substring_index] (batchId=1) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_to_utc_timestamp] (batchId=21) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_trunc] (batchId=3) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udf_width_bucket] (batchId=5) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[udtf_stack] (batchId=37) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_tablesample_rows] (batchId=49) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[insert_into1] (batchId=141) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[union_fast_stats] (batchId=156) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[drop_table_failure2] (batchId=89) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=234) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[insert_into1] (batchId=110) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[stats9] (batchId=113) org.apache.hadoop.hive.ql.TestAcidOnTez.testCtasTezUnion (batchId=215) org.apache.hadoop.hive.ql.TestAcidOnTez.testNonStandardConversion01 (batchId=215) org.apache.hadoop.hive.ql.parse.TestExportImport.shouldExportImportATemporaryTable (batchId=218) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6826/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6826/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6826/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 56 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12887195 - PreCommit-HIVE-Build > StatsUtil::getBasicStatForTable doesn't distinguish b/w absence of statistics > or zero stats > ------------------------------------------------------------------------------------------- > > Key: HIVE-17536 > URL: https://issues.apache.org/jira/browse/HIVE-17536 > Project: Hive > Issue Type: Improvement > Components: Statistics > Reporter: Vineet Garg > Assignee: Vineet Garg > Attachments: HIVE-17536.1.patch > > > This method returns zero for both of the following cases: > * Statistics are missing in metastore > * Actual stats e.g. number of rows are zero > It'll be good for this method to return e.g. -1 in absence of statistics > instead of assuming it to be zero. -- This message was sent by Atlassian JIRA (v6.4.14#64029)