[
https://issues.apache.org/jira/browse/HIVE-17261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16155410#comment-16155410
]
Ferdinand Xu edited comment on HIVE-17261 at 9/6/17 2:13 PM:
-------------------------------------------------------------
Thanks [~junjie] for the patch. Some comments left below:
In ParquetRecordReaderBase.java
# Please remove @ Depercated annotation since we are not using the deprecated
constructor in L65
# In L103 - L107, two space indents.
# Please update the setFilter method since the return value is no more needed.
# The searchArg is passing to setFilter as a final variable. Then the converted
filter property is not passed to Parquet reader?
was (Author: ferd):
Thanks [~junjie] for the patch. Some minor comments below:
In ParquetRecordReaderBase.java
# Please remove @ Depercated annotation since we are not using the deprecated
constructor in L65
# In L103 - L107, two space indents.
# Please update the setFilter method since the return value is no more needed.
# The searchArg is passing to setFilter as a final variable. Then the converted
filter property is not passed to Parquet reader?
> Hive use deprecated ParquetInputSplit constructor which blocked parquet
> dictionary filter
> -----------------------------------------------------------------------------------------
>
> Key: HIVE-17261
> URL: https://issues.apache.org/jira/browse/HIVE-17261
> Project: Hive
> Issue Type: Improvement
> Components: Database/Schema
> Affects Versions: 2.2.0
> Reporter: Junjie Chen
> Assignee: Junjie Chen
> Attachments: HIVE-17261.2.patch, HIVE-17261.3.patch,
> HIVE-17261.4.patch, HIVE-17261.diff, HIVE-17261.patch
>
>
> Hive use deprecated ParquetInputSplit in
> [https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/parquet/ParquetRecordReaderBase.java#L128]
> Please see interface definition in
> [https://github.com/apache/parquet-mr/blob/master/parquet-hadoop/src/main/java/org/apache/parquet/hadoop/ParquetInputSplit.java#L80]
> Old interface set rowgroupoffset values which will lead to skip dictionary
> filter in parquet.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
