[ https://issues.apache.org/jira/browse/HIVE-17307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147715#comment-16147715 ]
Vihang Karajgaonkar commented on HIVE-17307: -------------------------------------------- +1 LGTM. I added one minor comment on the PR and would be good if you could add a line of comment explaining a bit more there. Thanks for the changes [~alangates] > Change the metastore to not use the metrics code in hive/common > --------------------------------------------------------------- > > Key: HIVE-17307 > URL: https://issues.apache.org/jira/browse/HIVE-17307 > Project: Hive > Issue Type: Sub-task > Components: Metastore > Reporter: Alan Gates > Assignee: Alan Gates > Attachments: HIVE-17307.2.patch, HIVE-17307.3.patch, > HIVE-17307.4.patch, HIVE-17307.patch > > > As we move code into the standalone metastore module, it cannot use the > metrics in hive-common. We could copy the current Metrics interface or we > could change the metastore code to directly use codahale metrics. -- This message was sent by Atlassian JIRA (v6.4.14#64029)