[ https://issues.apache.org/jira/browse/HIVE-17257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116004#comment-16116004 ]
Hive QA commented on HIVE-17257: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12880576/HIVE-17257.0.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10990 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[create_merge_compressed] (batchId=239) org.apache.hadoop.hive.cli.TestBeeLineDriver.testCliDriver[insert_overwrite_local_directory_1] (batchId=239) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[llap_uncompressed] (batchId=56) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[columnstats_part_coltype] (batchId=158) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[spark_vectorized_dynamic_partition_pruning] (batchId=168) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=234) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=234) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionRegistrationWithCustomSchema (batchId=179) org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSpecRegistrationWithCustomSchema (batchId=179) org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation (batchId=179) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/6274/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/6274/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-6274/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 10 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12880576 - PreCommit-HIVE-Build > Hive should merge empty files > ----------------------------- > > Key: HIVE-17257 > URL: https://issues.apache.org/jira/browse/HIVE-17257 > Project: Hive > Issue Type: Bug > Reporter: Chao Sun > Assignee: Chao Sun > Attachments: HIVE-17257.0.patch > > > Currently if merging file option is turned on and the dest dir contains large > number of empty files, Hive will not trigger merge task: > {code} > private long getMergeSize(FileSystem inpFs, Path dirPath, long avgSize) { > AverageSize averageSize = getAverageSize(inpFs, dirPath); > if (averageSize.getTotalSize() <= 0) { > return -1; > } > if (averageSize.getNumFiles() <= 1) { > return -1; > } > if (averageSize.getTotalSize()/averageSize.getNumFiles() < avgSize) { > return averageSize.getTotalSize(); > } > return -1; > } > {code} > This logic doesn't seem right as the it seems better to combine these empty > files into one. -- This message was sent by Atlassian JIRA (v6.4.14#64029)