[
https://issues.apache.org/jira/browse/HIVE-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16113621#comment-16113621
]
Sergey Shelukhin commented on HIVE-12369:
-----------------------------------------
Finished the first iteration of the diff #3.
My main comment is that the patch needs more comments, esp. for things that are
used elsewhere and hard to understand without context.
Also left some logic-specific/etc. comments on RB. I didn't read all the code
in great detail in the parts that look very similar for different types and
cases.
> Native Vector GroupBy
> ---------------------
>
> Key: HIVE-12369
> URL: https://issues.apache.org/jira/browse/HIVE-12369
> Project: Hive
> Issue Type: Bug
> Components: Hive
> Reporter: Matt McCline
> Assignee: Matt McCline
> Priority: Critical
> Attachments: HIVE-12369.01.patch, HIVE-12369.02.patch,
> HIVE-12369.05.patch, HIVE-12369.06.patch
>
>
> Implement Native Vector GroupBy using fast hash table technology developed
> for Native Vector MapJoin, etc.
> Patch is currently limited to a single Long key, aggregation on Long columns,
> no more than 31 columns.
> 3 new classes introduces that stored the count in the slot table and don't
> allocate hash elements:
> {noformat}
> COUNT(column) VectorGroupByHashOneLongKeyCountColumnOperator
> COUNT(key) VectorGroupByHashOneLongKeyCountKeyOperator
> COUNT(*) VectorGroupByHashOneLongKeyCountStarOperator
> {noformat}
> And a new class that aggregates a single Long key:
> {noformat}
> VectorGroupByHashOneLongKeyOperator
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
