[ https://issues.apache.org/jira/browse/HIVE-17160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16111082#comment-16111082 ]
Ashutosh Chauhan commented on HIVE-17160: ----------------------------------------- Overall looks good. Few comments: * For Base64 encoding you may use jdk8 lib java.util.Base64.RFC2045 and avoid dependency on apache commons. * Although there are comments for methods, add overall comments on use of cookie to avoid repeated challenge negotiations. As well as retrial when cookie expires. * Also add comment on advantage of using future task for connection, instead of doing it inline. * Unit tests have not run on this yet, so you need to reupload the patch. > Adding kerberos Authorization to the Druid hive integration > ----------------------------------------------------------- > > Key: HIVE-17160 > URL: https://issues.apache.org/jira/browse/HIVE-17160 > Project: Hive > Issue Type: New Feature > Components: Druid integration > Reporter: slim bouguerra > Assignee: slim bouguerra > Attachments: HIVE-17160.patch > > > This goal of this feature is to allow hive querying a secured druid cluster > using kerberos credentials. -- This message was sent by Atlassian JIRA (v6.4.14#64029)