[ https://issues.apache.org/jira/browse/HIVE-17217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110309#comment-16110309 ]
Gopal V commented on HIVE-17217: -------------------------------- The patch took me a few reads to understand. If someone removes the assert, it ends up with the last path replacing all others, which might not be obvious. {code} for (int i = 0; i < splits.size(); i++) { {code} is better written with i=1, so that the loop only compares and doesn't do a put(). +1, with that minor nit. > SMB Join : Assert if paths are different in TezGroupedSplit in > KeyValueInputMerger > ---------------------------------------------------------------------------------- > > Key: HIVE-17217 > URL: https://issues.apache.org/jira/browse/HIVE-17217 > Project: Hive > Issue Type: Bug > Reporter: Deepak Jaiswal > Assignee: Deepak Jaiswal > Attachments: HIVE-17217.1.patch > > > In KeyValueInputMerger, a TezGroupedSplit may contain more than 1 splits. > However, the splits should all belong to same path. -- This message was sent by Atlassian JIRA (v6.4.14#64029)