[ https://issues.apache.org/jira/browse/HIVE-17208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16108188#comment-16108188 ]
Thejas M Nair commented on HIVE-17208: -------------------------------------- ReplicationSemanticAnalyzer - Since the location is not specified by user, we don't need to check access to it. ReplDumpTask - matches* methods - "public static" (instead of "static public") is recommended sun convention (and therefore hive convention). ReplicationSemanticAnalyzer calling static method in ReplDumpTask is little unintuitive. How about moving that method to a higher level utils class ? Maybe org.apache.hadoop.hive.ql.parse.repl.dump.Utils class ? > Repl dump should pass in db/table information to authorization API > ------------------------------------------------------------------ > > Key: HIVE-17208 > URL: https://issues.apache.org/jira/browse/HIVE-17208 > Project: Hive > Issue Type: Bug > Components: Authorization > Reporter: Daniel Dai > Assignee: Daniel Dai > Attachments: HIVE-17208.1.patch > > > "repl dump" does not provide db/table information. That is necessary for > authorization replication in ranger. -- This message was sent by Atlassian JIRA (v6.4.14#64029)