[ https://issues.apache.org/jira/browse/HIVE-16077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16105429#comment-16105429 ]
Prasanth Jayachandran commented on HIVE-16077: ---------------------------------------------- +1. Looks good to me. Only comment is the one you had already mentioned in the patch related to closing on abort. Will be good to add that too. > UPDATE/DELETE fails with numBuckets > numReducers > ------------------------------------------------- > > Key: HIVE-16077 > URL: https://issues.apache.org/jira/browse/HIVE-16077 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 1.1.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Priority: Critical > Attachments: HIVE-16077.01.patch, HIVE-16077.02.patch, > HIVE-16077.03.patch, HIVE-16077.08.patch > > > don't think we have such tests for Acid path > check if they exist for non-acid path > way to record expected files on disk in ptest/qfile > https://github.com/apache/hive/blob/master/ql/src/test/queries/clientpositive/orc_merge3.q#L25 > dfs -ls ${hiveconf:hive.metastore.warehouse.dir}/orcfile_merge3b/; -- This message was sent by Atlassian JIRA (v6.4.14#64029)