[ 
https://issues.apache.org/jira/browse/HIVE-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16099157#comment-16099157
 ] 

Siddharth Seth commented on HIVE-17019:
---------------------------------------

Re-looked at the patch. Mostly looks good. Some comments and questions.
- How is the context set up for LogDownloadServlet. 
e.g.CONF_LOG_DOWNLODER_NUM_EXECUTORS. The config should likely be set up in 
HiveConf in some way.
- init for the servlet will happen once at startup? So if there's multiple 
requests to download, and the limit is hit, all webserver threads will block? 
Should we just return an error if there's too many parallel downloads, so that 
other parts of the UI continue to be functional.
- In terms of the security - this becomes interesting. Essentially says that 
the feature will only work if authentication is enabled on secure clusters.
- Timeout for the downloads as a separate jira?
- Are any credentials required on the HttpClient created to download artifacts 
from various end points?
- For Constants like TIMELINE_PATH_PREFIX - any chance YARN has a helper 
method? Otherwise we should file a jira to ask yarn to expose such utilities.
- Both dagId and queryId cannot be specified at the same time?


> Add support to download debugging information as an archive.
> ------------------------------------------------------------
>
>                 Key: HIVE-17019
>                 URL: https://issues.apache.org/jira/browse/HIVE-17019
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Harish Jaiprakash
>            Assignee: Harish Jaiprakash
>         Attachments: HIVE-17019.01.patch, HIVE-17019.02.patch, 
> HIVE-17019.03.patch
>
>
> Given a queryId or dagId, get all information related to it: like, tez am, 
> task logs, hive ats data, tez ats data, slider am status, etc. Package it 
> into and archive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to