[ 
https://issues.apache.org/jira/browse/HIVE-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16087357#comment-16087357
 ] 

BELUGA BEHR commented on HIVE-16880:
------------------------------------

[~dvoros] Thanks for the input.  You can see that this was an issue in my first 
submission (many failed unit tests).  It has since been addressed.  Using the 
immutable lists facilities are an excellent way to cut down on memory 
instantiation, garbage collection, and buffering simple operations like 
"isEmpty" or "size()".  Additionally, in the rare cases where collection 
equality is used, the {{==}} check will hit.  That's why these collections 
(Map, List) are included as part of the JDK.

> Remove ArrayList Instantiation For Empty Arrays
> -----------------------------------------------
>
>                 Key: HIVE-16880
>                 URL: https://issues.apache.org/jira/browse/HIVE-16880
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 2.1.1, 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>             Fix For: 3.0.0
>
>         Attachments: HIVE-16880.1.patch, HIVE-16880.2.patch
>
>
> Class {{org.apache.hadoop.hive.metastore.MetaStoreDirectSql}} uses a lot of 
> empty arrays in the code.  Please replace with a static empty array instead 
> of all the instantiation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to