[
https://issues.apache.org/jira/browse/HIVE-16269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005750#comment-16005750
]
Sushanth Sowmyan edited comment on HIVE-16269 at 5/11/17 1:15 AM:
------------------------------------------------------------------
Hi Anishek,
I'm +1 on the mechanics of the patch, and was about to commit it when I noticed
one thing - WareHouse.java that you are adding in this patch does not have a
Apache license header. Could you please update the patch with that added?
Also, if the patch needs updating anyway, I would suggest renaming
WareHouse.java - the name is problematic for 2 reasons:
a) Camel-casing WareHouse is not accurate, since warehouse is a single word in
most data processing connotations, not two separate words.
b) Warehouse.java itself already exists, and has a different connotation. Maybe
call the new file WarehouseInstance.java or something like that? That makes
things more clear.
If these changes are made, I think this is committable as-is. And since these
changes that I'm asking for are not functionality tests, as long as you rename
the file and add the license header and the tests added in this patch locally,
I can commit.
was (Author: sushanth):
Hi Anishek,
I'm +1 on the mechanics of the patch, and was about to commit it when I noticed
one thing - WareHouse.java that you are adding in this patch does not have a
Apache license header. Could you please update the patch with that added?
Also, if the patch needs updating anyway, I would suggest renaming
WareHouse.java - the name is problematic for 2 reasons:
a) Camel-casing WareHouse is not accurate, since warehouse is a single word in
most dataprocessing connotations, not two separate words.
b) Warehouse.java itself already exists, and has a different connotation. Maybe
call the new file WarehouseInstance.java or something like that? That makes
things more clear.
If these changes are made, I think this is committable as-is. And since these
changes that I'm asking for are not functionality tests, as long as you rename
the file and add the license header and the tests added in this patch locally,
I can commit.
> enable incremental function dump to be loaded via repl load
> ------------------------------------------------------------
>
> Key: HIVE-16269
> URL: https://issues.apache.org/jira/browse/HIVE-16269
> Project: Hive
> Issue Type: Sub-task
> Components: HiveServer2
> Affects Versions: 2.2.0
> Reporter: anishek
> Assignee: anishek
> Attachments: HIVE-16269.1.patch, HIVE-16269.2.patch
>
>
> depends if there is additional spec elements we put out as part of HIVE-16268
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
