[ 
https://issues.apache.org/jira/browse/HIVE-14412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rui Li updated HIVE-14412:
--------------------------
    Attachment: HIVE-14412.13.patch

Update to address [~ashutoshc]'s comments.
The reason why I didn't add qtest for conversion between timestamp and 
timestamptz is because, system time zone is used during the conversion. Meaning 
the qtest will give different results in different time zones. If developers 
want to update golden files in the future, they have to make sure their machine 
is in same zone as our Jenkins server.
I do have unit test for the conversion in TestTimestampTZ. Do you think that's 
OK?

> Add a timezone-aware timestamp
> ------------------------------
>
>                 Key: HIVE-14412
>                 URL: https://issues.apache.org/jira/browse/HIVE-14412
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Rui Li
>            Assignee: Rui Li
>         Attachments: HIVE-14412.10.patch, HIVE-14412.11.patch, 
> HIVE-14412.12.patch, HIVE-14412.13.patch, HIVE-14412.1.patch, 
> HIVE-14412.2.patch, HIVE-14412.3.patch, HIVE-14412.4.patch, 
> HIVE-14412.5.patch, HIVE-14412.6.patch, HIVE-14412.7.patch, 
> HIVE-14412.8.patch, HIVE-14412.9.patch
>
>
> Java's Timestamp stores the time elapsed since the epoch. While it's by 
> itself unambiguous, ambiguity comes when we parse a string into timestamp, or 
> convert a timestamp to string, causing problems like HIVE-14305.
> To solve the issue, I think we should make timestamp aware of timezone.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to