[ 
https://issues.apache.org/jira/browse/HIVE-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975158#comment-15975158
 ] 

Sahil Takiar commented on HIVE-16346:
-------------------------------------

[~aihuaxu] thanks for taking a look! I addressed your comments and updated the 
RB: https://reviews.apache.org/r/58183/

I attached a new patch all the failed tests are all flaky.

> inheritPerms should be conditional based on the target filesystem
> -----------------------------------------------------------------
>
>                 Key: HIVE-16346
>                 URL: https://issues.apache.org/jira/browse/HIVE-16346
>             Project: Hive
>          Issue Type: Sub-task
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-16346.1-branch-2.patch, HIVE-16346.2-branch-2.patch
>
>
> Right now, a lot of the logic in {{Hive.java}} attempts to set permissions of 
> different files that have been moved / copied. This is only triggered if 
> {{hive.warehouse.subdir.inherit.perms}} is set to true.
> However, on blobstores such as S3, there is no concept of file permissions so 
> these calls are unnecessary, which can hurt performance.
> One solution would be to set {{hive.warehouse.subdir.inherit.perms}} to 
> false, but this would be a global change that affects an entire HS2 instance. 
> So HDFS tables will no longer have permissions inheritance.
> A better solution would be to make the inheritance of permissions conditional 
> on the target filesystem.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to